Skip to content

Conversation

saurabhraghuvanshii
Copy link
Contributor

Notes for Reviewers
before:
Screenshot From 2025-08-09 01-41-15
Screenshot From 2025-08-09 01-52-48

After
Screenshot From 2025-08-09 03-22-32
Screenshot From 2025-08-09 03-22-41

This PR fixes # none

Signed commits

  • Yes, I signed my commits.

Signed-off-by: saurabhraghuvanshii <[email protected]>
@leecalcote leecalcote requested a review from amitamrutiya August 8, 2025 23:27
Signed-off-by: saurabhraghuvanshii <[email protected]>
@vr-varad
Copy link
Contributor

Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

Signed-off-by: saurabhraghuvanshii <[email protected]>
@saurabhraghuvanshii
Copy link
Contributor Author

@FaheemOnHub I update it but now it will work for all components, because other components which are using coustomTooltip if I changed for one components others are breaking so I updated for all components, I think which is good for consistency for all components used light color for light mode.

Screencast.From.2025-08-11.22-30-27.mp4

@leecalcote
Copy link
Member

Stick with the specific issue raised. Don't recolor all the other tooltips.

Signed-off-by: saurabhraghuvanshii <[email protected]>
Signed-off-by: saurabhraghuvanshii <[email protected]>
Signed-off-by: saurabhraghuvanshii <[email protected]>
@saurabhraghuvanshii
Copy link
Contributor Author

@leecalcote updated

Screencast.From.2025-08-13.13-49-52.mp4

Copy link
Contributor

@FaheemOnHub FaheemOnHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FaheemOnHub FaheemOnHub merged commit d954a95 into layer5io:master Aug 13, 2025
4 checks passed
@saurabhraghuvanshii saurabhraghuvanshii deleted the bold branch August 13, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants